Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Remove unused layer MadsimLayer #4788

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

zzzk1
Copy link
Contributor

@zzzk1 zzzk1 commented Jun 22, 2024

close: #4689

@zzzk1 zzzk1 requested a review from Xuanwo as a code owner June 22, 2024 13:32
@github-actions github-actions bot requested review from dqhl76 and G-XD June 22, 2024 13:33
@zzzk1 zzzk1 force-pushed the Remove-MadsimLayer branch from ff96412 to c3df282 Compare June 22, 2024 13:39
@zzzk1 zzzk1 changed the title refactor(core) Remove unused layer MadsimLayer refactor(core): Remove unused layer MadsimLayer Jun 22, 2024
@zzzk1 zzzk1 force-pushed the Remove-MadsimLayer branch 2 times, most recently from 7857371 to de27833 Compare June 22, 2024 14:01
Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM

core/Cargo.toml Show resolved Hide resolved
@zzzk1 zzzk1 force-pushed the Remove-MadsimLayer branch from de27833 to 5c1ff89 Compare June 27, 2024 13:46
@PsiACE PsiACE merged commit 05d6b84 into apache:main Jun 27, 2024
219 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup: Remove MadsimLayer
2 participants