-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add OpenDAL Compat #5185
feat: Add OpenDAL Compat #5185
Conversation
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM : )
IMO the old operator should be tested against the previous tests , not current tests. For example, #4959 has modified the related tests. In this case, it's impossible for the old operator to pass the new tests. (If I cited the wrong case, please remind me.) While this situation is relatively uncommon, I believe it’s one of the aspects you aim to address by introducing this crate. |
After using
Unfortunately, we are unable to implement this. Users will still need to be mindful of the behavioral changes. |
OK. So the compat feature doesn't guarantee the behavior is compatible after the upgrade. It is sad. |
Yes, just ensure that the application can continue building. The maintenance burden is too high for us to ensure behavior compatibility as well. I will make it clear in our docs. |
Signed-off-by: Xuanwo <[email protected]>
CC @yuchanns, please review |
LGTM on green |
Which issue does this PR close?
Closes #5180.
Rationale for this change
Make users' lives easier when they need to work with different versions of OpenDAL.