Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC-5313: Remove Metakey #5313

Merged
merged 3 commits into from
Nov 13, 2024
Merged

RFC-5313: Remove Metakey #5313

merged 3 commits into from
Nov 13, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Nov 12, 2024

Which issue does this PR close?

Result of #5287

Rationale for this change

New RFC.

What changes are included in this PR?

Are there any user-facing changes?

Not yet.

Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo changed the title rfc: Remove Metakey RFC-5313: Remove Metakey Nov 12, 2024
Signed-off-by: Xuanwo <[email protected]>
Copy link
Member

@koushiro koushiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 13, 2024

Generally LGTM

All suggestions have been applied. Please review again, thanks!

@Xuanwo Xuanwo merged commit 7b18680 into main Nov 13, 2024
260 checks passed
@Xuanwo Xuanwo deleted the rfc-remove-metakey branch November 13, 2024 04:29
let entries = op.list("path").await?;
for entry in entries {
let mut meta = entry.metadata();
if !op.metadata_capability().etag {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on this usage, it seems to be the metadata capability of the list operation ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants