Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add {stat,list}_has_* to carry the metadata that backend returns #5318

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Nov 13, 2024

Which issue does this PR close?

Part of #5314

Rationale for this change

Allow users to know which metadata will exist in stat and list before calling.

This PR is bit misalign with the RFC, will update back.

What changes are included in this PR?

This PR adds the {stat,list}_has_* in capability to carry the metadata that backend returns

Are there any user-facing changes?

Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #5318 will degrade performances by 21.21%

Comparing remove-metakey (7c842aa) with main (41b6f27)

Summary

⚡ 1 improvements
❌ 12 regressions
✅ 60 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main remove-metakey Change
buffer 256 KiB * 32 chunk 183.6 ns 212.8 ns -13.71%
buffer 256 KiB * 4 chunk 154.4 ns 183.6 ns -15.89%
buffer 4.00 MiB * 32 chunk 154.4 ns 183.6 ns -15.89%
buffer 4.00 MiB * 4 chunk 154.4 ns 183.6 ns -15.89%
256 KiB * 1000k chunk 154.4 ns 183.6 ns -15.89%
256 KiB * 1000k truncate 216.7 ns 275 ns -21.21%
256 KiB * 100k chunk 154.4 ns 183.6 ns -15.89%
256 KiB * 100k truncate 216.7 ns 275 ns -21.21%
256 KiB * 10k chunk 183.6 ns 212.8 ns -13.71%
256 KiB * 10k truncate 216.7 ns 275 ns -21.21%
256 KiB * 1k chunk 154.4 ns 183.6 ns -15.89%
256 KiB * 1k truncate 216.7 ns 275 ns -21.21%
concurrent 16 321 µs 289.1 µs +11.02%

Copy link
Member

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Xuanwo Xuanwo merged commit 297bbf9 into main Nov 13, 2024
275 checks passed
@Xuanwo Xuanwo deleted the remove-metakey branch November 13, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants