Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Implement write if not exists for azblob,azdls,gcs,oss,cos #5321

Merged
merged 7 commits into from
Nov 14, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Nov 14, 2024

Signed-off-by: Xuanwo [email protected]

Which issue does this PR close?

Closes #5218

Rationale for this change

None.

What changes are included in this PR?

Implement condition write for all supported storage services.

Are there any user-facing changes?

Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Copy link

codspeed-hq bot commented Nov 14, 2024

CodSpeed Performance Report

Merging #5321 will degrade performances by 18.88%

Comparing add-write-if-not-exists (f8152be) with main (4dc0f15)

Summary

❌ 8 regressions
✅ 65 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main add-write-if-not-exists Change
buffer 256 KiB * 32 chunk 154.4 ns 183.6 ns -15.89%
buffer 256 KiB * 4 chunk 125.3 ns 154.4 ns -18.88%
buffer 4.00 MiB * 32 chunk 125.3 ns 154.4 ns -18.88%
buffer 4.00 MiB * 4 chunk 125.3 ns 154.4 ns -18.88%
256 KiB * 1000k truncate 245.8 ns 275 ns -10.61%
256 KiB * 100k truncate 245.8 ns 275 ns -10.61%
256 KiB * 10k truncate 245.8 ns 275 ns -10.61%
256 KiB * 1k truncate 245.8 ns 275 ns -10.61%

Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo requested review from PsiACE and koushiro November 14, 2024 11:27
@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 14, 2024

Thank you @ClSlaid for the review!

@Xuanwo Xuanwo merged commit 084892f into main Nov 14, 2024
122 checks passed
@Xuanwo Xuanwo deleted the add-write-if-not-exists branch November 14, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issues with Conditional Write
2 participants