Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Implement RFC-3911 Deleter API #5392

Merged
merged 18 commits into from
Dec 5, 2024
Merged

refactor: Implement RFC-3911 Deleter API #5392

merged 18 commits into from
Dec 5, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Dec 5, 2024

Signed-off-by: Xuanwo [email protected]

Which issue does this PR close?

A big part of #3922

Rationale for this change

Implement RFC.

What changes are included in this PR?

This PR implements all needed things to unblock further development.

Are there any user-facing changes?

Enable users to remove a large stream of files.

Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Copy link

codspeed-hq bot commented Dec 5, 2024

CodSpeed Performance Report

Merging #5392 will degrade performances by 21.37%

Comparing deleter (6869a44) with main (f3bf1d4)

Summary

⚡ 8 improvements
❌ 1 regressions
✅ 64 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main deleter Change
buffer 256 KiB * 32 chunk 183.6 ns 125.3 ns +46.56%
buffer 256 KiB * 4 chunk 183.6 ns 125.3 ns +46.56%
buffer 4.00 MiB * 32 chunk 183.6 ns 125.3 ns +46.56%
buffer 4.00 MiB * 4 chunk 183.6 ns 125.3 ns +46.56%
256 KiB * 1000k chunk 183.6 ns 154.4 ns +18.88%
256 KiB * 100k chunk 183.6 ns 154.4 ns +18.88%
256 KiB * 10k chunk 183.6 ns 154.4 ns +18.88%
256 KiB * 1k chunk 212.8 ns 183.6 ns +15.89%
concurrent 8 355.2 µs 451.7 µs -21.37%

Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo requested review from George-Miao and dqhl76 December 5, 2024 15:08
@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 5, 2024

NOTEs to reviewer:

  • Most changes are related to Access API changes
  • Meaningful changes happened in operator.rs and delete.rs.

Ok(())
}

/// Delete an infallible iterator of paths.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fallible?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

core/src/types/operator/operator.rs Outdated Show resolved Hide resolved
core/src/types/operator/operator.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only reviewed the core part (under oio) and not any of the services or layers. I trust you on that.

@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 5, 2024

Thank you @George-Miao for the review!

@Xuanwo Xuanwo merged commit c77a07a into main Dec 5, 2024
275 checks passed
@Xuanwo Xuanwo deleted the deleter branch December 5, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants