-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to v0.51.0 rc1 #5413
Conversation
Signed-off-by: Manjusaka <[email protected]>
Signed-off-by: Manjusaka <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Zheaoli, thank you for creating this. It looks great to me overall, except for some incorrect version bumps.
bindings/c/Cargo.toml
Outdated
@@ -25,7 +25,7 @@ homepage = "https://opendal.apache.org/" | |||
license = "Apache-2.0" | |||
repository = "https://github.com/apache/opendal" | |||
rust-version = "1.75" | |||
version = "0.45.1" | |||
version = "0.46.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to bump this? It seems there are no breaking changes for C and C++.
bindings/dotnet/Cargo.toml
Outdated
@@ -18,7 +18,7 @@ | |||
[package] | |||
name = "opendal-dotnet" | |||
publish = false | |||
version = "0.1.11" | |||
version = "0.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same.
bindings/haskell/Cargo.toml
Outdated
@@ -25,7 +25,7 @@ homepage = "https://opendal.apache.org/" | |||
license = "Apache-2.0" | |||
repository = "https://github.com/apache/opendal" | |||
rust-version = "1.75" | |||
version = "0.44.13" | |||
version = "0.45.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same. We only need to bump it when breaking changes happen.
bindings/java/Cargo.toml
Outdated
@@ -25,7 +25,7 @@ homepage = "https://opendal.apache.org/" | |||
license = "Apache-2.0" | |||
repository = "https://github.com/apache/opendal" | |||
rust-version = "1.75" | |||
version = "0.47.5" | |||
version = "0.48.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same.
bindings/lua/Cargo.toml
Outdated
@@ -18,7 +18,7 @@ | |||
[package] | |||
name = "opendal-lua" | |||
publish = false | |||
version = "0.1.11" | |||
version = "0.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same.
bindings/nodejs/Cargo.toml
Outdated
@@ -25,7 +25,7 @@ homepage = "https://opendal.apache.org/" | |||
license = "Apache-2.0" | |||
repository = "https://github.com/apache/opendal" | |||
rust-version = "1.75" | |||
version = "0.47.7" | |||
version = "0.48.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same.
bindings/php/Cargo.toml
Outdated
@@ -18,7 +18,7 @@ | |||
[package] | |||
name = "opendal-php" | |||
publish = false | |||
version = "0.1.11" | |||
version = "0.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same.
bindings/python/Cargo.toml
Outdated
@@ -25,7 +25,7 @@ homepage = "https://opendal.apache.org/" | |||
license = "Apache-2.0" | |||
repository = "https://github.com/apache/opendal" | |||
rust-version = "1.75" | |||
version = "0.45.12" | |||
version = "0.46.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same.
bindings/ruby/Cargo.toml
Outdated
@@ -18,7 +18,7 @@ | |||
[package] | |||
name = "opendal-ruby" | |||
publish = false | |||
version = "0.1.11" | |||
version = "0.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same.
For me, when the core is in a new big version. I prefer upgrade the binding to a new big version at the same time. This is a personal style. On your call. |
Core changes should always be hidden from binding users. So let's just bump patch versions unless the binding itself has breaking changes. |
Signed-off-by: Manjusaka <[email protected]>
@Xuanwo PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this!
Which issue does this PR close?
Part of #5412
What changes are included in this PR?