Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(services/s3): List with deleted should contain latest #5518

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jan 7, 2025

Which issue does this PR close?

Closes #5507

Rationale for this change

See #5507

What changes are included in this PR?

Make sure latest version is included.

Are there any user-facing changes?

@Xuanwo Xuanwo requested a review from meteorgan January 7, 2025 13:50
Copy link

codspeed-hq bot commented Jan 7, 2025

CodSpeed Performance Report

Merging #5518 will improve performances by 18.88%

Comparing fix-list-with-deleted (fa98026) with main (4fe235a)

Summary

⚡ 4 improvements
✅ 69 untouched benchmarks

Benchmarks breakdown

Benchmark main fix-list-with-deleted Change
256 KiB * 1000k chunk 183.6 ns 154.4 ns +18.88%
256 KiB * 100k chunk 183.6 ns 154.4 ns +18.88%
256 KiB * 10k chunk 183.6 ns 154.4 ns +18.88%
256 KiB * 1k chunk 212.8 ns 183.6 ns +15.89%

@Xuanwo Xuanwo requested a review from meteorgan January 7, 2025 14:11
@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 7, 2025

Hi, @meteorgan, please review again.

@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 7, 2025

Thank you @meteorgan for the review!

@Xuanwo Xuanwo merged commit b212297 into main Jan 7, 2025
276 checks passed
@Xuanwo Xuanwo deleted the fix-list-with-deleted branch January 7, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: the implement of list_with_deleted is not consistent with the RFC-5495
2 participants