feat(services/onedrive): List dir shows metadata #5632
Conversation
Most my test folders have 0 in size, but one has 3. I didn't dig into it.
core/src/services/onedrive/lister.rs
Outdated
| oio::Entry::new(&normalized_path, Metadata::new(EntryMode::FILE)) | ||
| } | ||
| let mut meta = Metadata::new(entry_mode) | ||
| .with_last_modified( |
There was a problem hiding this comment.
we have some time functions in chrono_utils.rs, like: parse_datetime_from_rfc2822. Maybe we could reuse them.
There was a problem hiding this comment.
Thanks for the tip, added.
I remembered that we failed to set up a OneDrive test. |
erickguan
force-pushed
the
onedrive-metadata
branch
3 times, most recently
from
26c9d63 to
3e64864
Compare
|
I generated a token from a personal test account with Additional permissions are useful for API Graph explorer which I recommend:
What do you want me next? These actions look sensible:
|
erickguan
force-pushed
the
onedrive-metadata
branch
from
3e64864 to
db4c88b
Compare
Since we don't have a test workflow for this, have you run the tests locally ? You can use the command |
Which issue does this PR close?
Part of #4746.
What changes are included in this PR?
Supports OneDrive lister with metadata.