Skip to content

ORC-1924: Add Windows 2025 GitHub Action job #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

Why are the changes needed?

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

@github-actions github-actions bot added the INFRA label Jun 17, 2025
@dongjoon-hyun dongjoon-hyun changed the title Test Windows 2025 Add Windows 2025 GitHub Action job Jun 17, 2025
@dongjoon-hyun dongjoon-hyun changed the title Add Windows 2025 GitHub Action job ORC-1924: Add Windows 2025 GitHub Action job Jun 17, 2025
@dongjoon-hyun
Copy link
Member Author

Just for the record, Windows 2022 is in the same situation because the Visual Studio version is identical on both environments. So, Windows 2025 is better.

dongjoon-hyun added a commit that referenced this pull request Jun 17, 2025
### What changes were proposed in this pull request?

This PR aims to remove `Windows 2019` GitHub Action job.

Note that ORC-1924 is created in order to recover Windows test coverage later.
- #2273

### Why are the changes needed?

`Windows 2019` is deprecated already and will be removed soon.
- actions/runner-images#12045

### How was this patch tested?

Manual review because this is a removal of CI.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #2274 from dongjoon-hyun/ORC-1923.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun added a commit that referenced this pull request Jun 17, 2025
### What changes were proposed in this pull request?

This PR aims to remove `Windows 2019` GitHub Action job.

Note that ORC-1924 is created in order to recover Windows test coverage later.
- #2273

### Why are the changes needed?

`Windows 2019` is deprecated already and will be removed soon.
- actions/runner-images#12045

### How was this patch tested?

Manual review because this is a removal of CI.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #2274 from dongjoon-hyun/ORC-1923.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 7e452b9)
Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun added a commit that referenced this pull request Jun 17, 2025
This PR aims to remove `Windows 2019` GitHub Action job.

Note that ORC-1924 is created in order to recover Windows test coverage later.
- #2273

`Windows 2019` is deprecated already and will be removed soon.
- actions/runner-images#12045

Manual review because this is a removal of CI.

No.

Closes #2274 from dongjoon-hyun/ORC-1923.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 7e452b9)
Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun added a commit that referenced this pull request Jun 17, 2025
This PR aims to remove `Windows 2019` GitHub Action job.

Note that ORC-1924 is created in order to recover Windows test coverage later.
- #2273

`Windows 2019` is deprecated already and will be removed soon.
- actions/runner-images#12045

Manual review because this is a removal of CI.

No.

Closes #2274 from dongjoon-hyun/ORC-1923.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 7e452b9)
Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun added a commit that referenced this pull request Jun 17, 2025
This PR aims to remove `Windows 2019` GitHub Action job.

Note that ORC-1924 is created in order to recover Windows test coverage later.
- #2273

`Windows 2019` is deprecated already and will be removed soon.
- actions/runner-images#12045

Manual review because this is a removal of CI.

No.

Closes #2274 from dongjoon-hyun/ORC-1923.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 7e452b9)
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant