Delay expansion of variables until after the config is parsed. #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… approach expanded variables even if they wqere is comments and so crashed on commented out configs
|
All tests run with the new changes. |
|
Sean, I can withdraw my PR and wait for yours to be merged.
Joe Drumgoole
+087 2995547
https://bsky.app/profile/joedrumgoole.com
…On Tue 12 Aug 2025, 15:31 Sean McCarthy, ***@***.***> wrote:
*smccarthy788* left a comment (apache/otava#87)
<#87 (comment)>
I have a PR which will remove expandvars entirely: #86
<#86>. I think that was one of the
goals for #82 <#82>, to remove
arbitrary environment variables from the config. Happy for any feedback on
that PR though!
—
Reply to this email directly, view it on GitHub
<#87 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAXYDU45KAB64OU2NPSGZL3NH3EBAVCNFSM6AAAAACDWUARNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNZZGYYDONRYGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hey Sean,
Can I help with getting your PR merged?
Joe.
…On Tue, 12 Aug 2025 at 17:54, Joe Drumgoole ***@***.***> wrote:
Sean, I can withdraw my PR and wait for yours to be merged.
Joe Drumgoole
+087 2995547
https://bsky.app/profile/joedrumgoole.com
On Tue 12 Aug 2025, 15:31 Sean McCarthy, ***@***.***> wrote:
> *smccarthy788* left a comment (apache/otava#87)
> <#87 (comment)>
>
> I have a PR which will remove expandvars entirely: #86
> <#86>. I think that was one of the
> goals for #82 <#82>, to remove
> arbitrary environment variables from the config. Happy for any feedback on
> that PR though!
>
> —
> Reply to this email directly, view it on GitHub
> <#87 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAAXYDU45KAB64OU2NPSGZL3NH3EBAVCNFSM6AAAAACDWUARNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNZZGYYDONRYGY>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
Joe Drumgoole
+087 2995547
https://bsky.app/profile/joedrumgoole.com
|
|
Hey Joe,
Thanks for offering to help. I pushed up a couple changes. There wasn’t much left. Review feedback would be much appreciated!
Sean
… On Aug 19, 2025, at 9:21 AM, Joe Drumgoole ***@***.***> wrote:
jdrumgoole
left a comment
(apache/otava#87)
<#87 (comment)>Hey Sean,
Can I help with getting your PR merged?
Joe.
On Tue, 12 Aug 2025 at 17:54, Joe Drumgoole ***@***.***> wrote:
> Sean, I can withdraw my PR and wait for yours to be merged.
>
>
> Joe Drumgoole
>
> +087 2995547
> https://bsky.app/profile/joedrumgoole.com
>
>
>
> On Tue 12 Aug 2025, 15:31 Sean McCarthy, ***@***.***> wrote:
>
>> *smccarthy788* left a comment (apache/otava#87)
>> <#87 (comment)>
>>
>> I have a PR which will remove expandvars entirely: #86
>> <#86>. I think that was one of the
>> goals for #82 <#82>, to remove
>> arbitrary environment variables from the config. Happy for any feedback on
>> that PR though!
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <#87 (comment)>, or
>> unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/AAAXYDU45KAB64OU2NPSGZL3NH3EBAVCNFSM6AAAAACDWUARNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNZZGYYDONRYGY>
>> .
>> You are receiving this because you authored the thread.Message ID:
>> ***@***.***>
>>
>
--
Joe Drumgoole
+087 2995547
https://bsky.app/profile/joedrumgoole.com
—
Reply to this email directly, view it on GitHub <#87 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABSLUQP5XSLCG7TQAKH23YL3OMQGTAVCNFSM6AAAAACDWUARNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMBQG42DSMRQG4>.
You are receiving this because you commented.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
expandvars()is run on the raw text of the config file prior to yaml parsing. This has the effect of trying to expand variables even in commented out code. With this approach we only expand the variables after the yaml parsing is complete.