refactor: Refactor DateTypes to make it more easy to use #29
Conversation
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
| @@ -329,44 +225,40 @@ impl BinaryType { | |||
|
|
|||
| pub const DEFAULT_LENGTH: usize = 1; | |||
|
|
|||
| pub fn new(is_nullable: bool, length: usize) -> Self { | |||
| Self::try_new(is_nullable, length).unwrap() | |||
| pub fn new(length: usize) -> Result<Self, &'static str> { | |||
There was a problem hiding this comment.
You might consider unifying the error types, such as using InvalidXXXType, and applying the same approach in other areas as well.
There was a problem hiding this comment.
You might consider unifying the error types, such as using InvalidXXXType, and applying the same approach in other areas as well.
Yes, we've directly migrated the code here without refactoring errors to clarify the scope of this PR. We can finish this part later.
There was a problem hiding this comment.
Would you like to perform this refactor? The error type has been defined at
paimon-rust/crates/paimon/src/error.rs
Lines 25 to 40 in a5cfac7
| /// Returns true if the data type is nullable. | ||
| /// | ||
| /// Impl Reference: <https://github.com/apache/paimon/blob/release-0.8.2/paimon-common/src/main/java/org/apache/paimon/types/DataType.java#L59> | ||
| fn is_nullable(&self) -> bool { |
There was a problem hiding this comment.
Is this method should be kept for the DataType ?
There was a problem hiding this comment.
Yes, we can implement in following PRs.
This PR refactor data types to make it more easy to use in rust.
Some
Displaydoesn't implemented correctly, I removed them in this PR. We can add them back in following PRs.