Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flink] Adopt getTaskInfo() when acquiring parallelism info #4583

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

yunfengzhou-hub
Copy link
Contributor

Purpose

Linked issue: #4442

This pull request adopts RuntimeContext#getTaskInfo when acquiring parallelism information.

Tests

Existing test cases are used to verify this change.

API and Format

This change does not affect API or storage format.

Documentation

This change does not affect introduce a new feature.

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove RuntimeContextUtils for old flink versions, do some tests fail?

@yunfengzhou-hub
Copy link
Contributor Author

If you remove RuntimeContextUtils for old flink versions, do some tests fail?

Yes some tests will fail. In old flink versions there is no RuntimeContext#getTaskInfo, so we need to use getRuntimeContext().getIndexOfThisSubtask() instead of getRuntimeContext().getTaskInfo().getIndexOfThisSubtask() in these versions.

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit ca4af64 into apache:master Nov 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants