Skip to content

[hive] Fix sync-all-properties cannot configurable #6271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[hive] Fix sync-all-properties cannot configurable #6271

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25e0682
1
Akwangg Sep 17, 2025
d8889d2
fix
Akwangg Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1054,7 +1054,7 @@ private Table createHiveTable(
checkArgument(Options.fromMap(options).get(TYPE) != FORMAT_TABLE);

Map<String, String> tblProperties;
if (syncAllProperties()) {
if (syncAllProperties(options)) {
tblProperties = new HashMap<>(options);
// add primary-key, partition-key to tblproperties
tblProperties.putAll(convertToPropertiesTableKey(tableSchema));
Expand Down Expand Up @@ -1210,8 +1210,10 @@ protected boolean allowCustomTablePath() {
return true;
}

public boolean syncAllProperties() {
return catalogOptions.get(SYNC_ALL_PROPERTIES);
public boolean syncAllProperties(Map<String, String> tableOptions) {
Map<String, String> merged = new HashMap<>(catalogOptions.toMap());
merged.putAll(tableOptions);
return new Options(merged).get(SYNC_ALL_PROPERTIES);
}

@Override
Expand Down Expand Up @@ -1570,12 +1572,12 @@ private void updateHmsTable(
}

private void updateHmsTablePars(Table table, TableSchema schema, Set<String> removedOptions) {
if (syncAllProperties()) {
table.getParameters().putAll(schema.options());
Map<String, String> options = schema.options();
if (syncAllProperties(options)) {
table.getParameters().putAll(options);
table.getParameters().putAll(convertToPropertiesTableKey(schema));
} else {
table.getParameters()
.putAll(convertToPropertiesPrefixKey(schema.options(), HIVE_PREFIX));
table.getParameters().putAll(convertToPropertiesPrefixKey(options, HIVE_PREFIX));
}
removedOptions.forEach(table.getParameters()::remove);
}
Expand Down
Loading