[core] Add deleted index generation to bucketed dv and hash maintainer #6349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zouxxyy
commented
Sep 29, 2025
| } | ||
|
|
||
| old.clean(); | ||
| // Keep the old deletion file. |
There was a problem hiding this comment.
Here, we should keep the old deletion file
| } | ||
| modified = false; | ||
| return Collections.singletonList(entry); | ||
| IndexFileMeta toRemove = beforeFile; |
There was a problem hiding this comment.
In the streaming scenario, the index maintainer will always hold it and not create it repeatedly, so this logic needs to be added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add deleted index generation to bucketed dv and hash maintainer.
Therefore, we can fully include the deleted index and added index in the commit message for subsequent conflict detection.
Tests
API and Format
Documentation