Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PARQUET-2460] Removing deprecated code #237

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

vinooganesh
Copy link
Contributor

This PR removes the deprecated parquet-format java code as discussed at the monthly meeting and email list.

Jira

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Published the JAR locally, and checked it against parquet-mr and nothing breaks :) Thanks for cleaning this up @vinooganesh

@vinooganesh
Copy link
Contributor Author

Thanks for testing @Fokko!

@Fokko Fokko merged commit 4cbb4cf into apache:master Apr 23, 2024
3 checks passed
@vinooganesh vinooganesh deleted the vinooganesh/removeDeprecatedCode branch April 23, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants