Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-2139: Clarify ColumnChunk::file_offset is not used #439

Closed
wants to merge 1 commit into from

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 25, 2024

See also mailint list discussion: https://lists.apache.org/thread/r6r2cvzrdoorq6h6gqwh0b1hbfbhxv29

This field is not written correctly in the Java implementation and it not read in other implementations (like rust). Let's clarify this in the format docs

Jira/GH

Related to apache/parquet-java#2678

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@alamb
Copy link
Contributor Author

alamb commented Jun 25, 2024

Superseded by #440

@alamb alamb closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant