PARQUET-2401: Synchronize on final fields (#1224)

apache · Dec 4, 2023 · 44fa76b · 44fa76b
1 parent 84b84e9
commit 44fa76b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/KeyToolkit.java b/parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/KeyToolkit.java
@@ -90,7 +90,7 @@ public class KeyToolkit {
   public static final int KEK_LENGTH_DEFAULT = 128;
 
   private static long lastCacheCleanForKeyRotationTime = 0;
-  private static Object lastCacheCleanForKeyRotationTimeLock = new Object();
+  private static final Object lastCacheCleanForKeyRotationTimeLock = new Object();
   // KMS servers typically allow to run key rotation once in a few hours / a day.
   // We clean KEK writer cache (if needed) after 1 hour
   private static final int CACHE_CLEAN_PERIOD_FOR_KEY_ROTATION = 60 * 60 * 1000; // 1 hour

diff --git a/parquet-hadoop/src/test/java/org/apache/parquet/crypto/TestPropertiesDrivenEncryption.java b/parquet-hadoop/src/test/java/org/apache/parquet/crypto/TestPropertiesDrivenEncryption.java
@@ -158,7 +158,7 @@ public static Collection<Object[]> data() {
   public TemporaryFolder temporaryFolder = new TemporaryFolder();
 
   @Rule
-  public ErrorCollector errorCollector = new ErrorCollector();
+  public final ErrorCollector errorCollector = new ErrorCollector();
 
   private static final Base64.Encoder encoder = Base64.getEncoder();
   private static final String FOOTER_MASTER_KEY =