Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-2348: Recompression/Re-encrypt should rewrite bloomfilter #1143

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

ConeyLiu
Copy link
Contributor

@ConeyLiu ConeyLiu commented Sep 18, 2023

The bloomfilter data is lost after rewriting with recompression or re-encrypt. We should rewrite the bloomfilter data as well.

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@ConeyLiu
Copy link
Contributor Author

Hi @wgtmac, could you help to review this? Thanks in advance.

@ConeyLiu
Copy link
Contributor Author

@wgtmac could you take another look, thanks.

Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Thanks for adding these tests!

@wgtmac wgtmac merged commit de08d8d into apache:master Oct 12, 2023
@ConeyLiu
Copy link
Contributor Author

Thanks @wgtmac

@ConeyLiu ConeyLiu deleted the rewrite-bloom branch October 12, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants