PARQUET-2463: Bump japicmp to 0.21.0 #1329
Conversation
|
This PR aims to minimize the exclusions from japicmp plugin before releasing 1.14.0. Please take a look, thanks! |
pom.xml
Outdated
| <exclude>org.apache.parquet.proto.ProtoParquetReader#builder(org.apache.parquet.io.InputFile,boolean)</exclude> | ||
|
|
||
| <!-- Due to protected field type change from Configuration to ParquetConfiguration --> | ||
| <exclude>org.apache.parquet.hadoop.CodecFactory#configuration</exclude> |
There was a problem hiding this comment.
These two exclusions are reported here: #1141 (comment). I'm not sure if this should be fixed.
There was a problem hiding this comment.
Well, if the field is protected, then technically we introduce breaking changes by altering them. I think, the question is how easy would it be to fix it in the code. If it requires big changes/redesign, I am fine having the exclusions. Otherwise, let's fix it in the code. We should avoid the practice of adding exclusions instead of trying to make backward compatible code.
There was a problem hiding this comment.
Thanks a lot @wgtmac for working on this! It looks good to me. Please check the field type change issues if they are fixable. If you think it requires too much effort I'll give the +1 for as is.
| protected final int pageSize; | ||
|
|
||
| // May be null if parquetConfiguration is not an instance of org.apache.parquet.conf.HadoopParquetConfiguration | ||
| @Deprecated | ||
| protected final Configuration configuration; |
There was a problem hiding this comment.
I've added it back to be backward compatible. @amousavigourabi @Fokko
|
I have fixed all issues. Please take a look again. Thanks! @gszadovszky |
|
Thanks @gszadovszky for the review! |
Make sure you have checked all steps below.
Jira
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
the ASF 3rd Party License Policy.
Tests
Commits
from "How to write a good git commit message":
Style
mvn spotless:apply -Pvector-pluginsDocumentation