PARQUET-196: parquet-tools command to get rowcount & size #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @prateek, thanks for working on this! Unfortunately, we didn't do a good enough job coordinating the work on PARQUET-196, because #132 already implemented the rowcount command. But you've done some good stuff in this PR that I'd like to get in as well. Would it be possible for you to base this on the work already done in the other PR so we can merge this after we merge that one? It would be great if you could also help us review the other PR and point out things that you did or thought about that could improve it. |
|
Hey @rdblue. Dang, I didn't look through existing PRs for the project, lesson learned. I'll be happy to assist with the other PR and add the stuff from here back in after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created new command for
rowcountstats and updatedmetacommand to support summary and human readable flags.