Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade pekko and build tool versions #198

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

pjfanning
Copy link
Contributor

  • pekko 1.0.2

He-Pin

This comment was marked as outdated.

@He-Pin
Copy link
Member

He-Pin commented Dec 25, 2023

gradle tests is down

    java.lang.IllegalStateException: You are using version 1.0.2 of Apache Pekko, but it appears you (perhaps indirectly) also depend on older versions of related artifacts. You can solve this by adding an explicit dependency on version 1.0.2 of the [pekko-stream-testkit, pekko-testkit] artifacts to your project. Here's a complete collection of detected artifacts: (1.0.1, [pekko-stream-testkit, pekko-testkit]), (1.0.2, [pekko-actor, pekko-discovery, pekko-protobuf-v3, pekko-stream]). See also: 

@pjfanning pjfanning marked this pull request as draft December 25, 2023 20:19
@pjfanning
Copy link
Contributor Author

gradle tests is down

    java.lang.IllegalStateException: You are using version 1.0.2 of Apache Pekko, but it appears you (perhaps indirectly) also depend on older versions of related artifacts. You can solve this by adding an explicit dependency on version 1.0.2 of the [pekko-stream-testkit, pekko-testkit] artifacts to your project. Here's a complete collection of detected artifacts: (1.0.1, [pekko-stream-testkit, pekko-testkit]), (1.0.2, [pekko-actor, pekko-discovery, pekko-protobuf-v3, pekko-stream]). See also: 

thanks - I'll have a look at the Gradle tests to see why this is happening (but maybe not tonight)

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a group of explict deps to make sure all pekko version keeps in sync

@He-Pin
Copy link
Member

He-Pin commented Dec 25, 2023

@pjfanning pjfanning marked this pull request as ready for review December 25, 2023 20:38
@pjfanning
Copy link
Contributor Author

@He-Pin test issue fixed - the 1.0.1 version appears in a few places

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 94b062e into apache:main Dec 25, 2023
15 of 16 checks passed
@pjfanning pjfanning deleted the upgrade-versions branch December 25, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants