test with sslcontext #205
Merged
test with sslcontext #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update tests
pjfanning
requested review from
He-Pin,
nvollmar,
mdedetrich and
samueleresca
He-Pin
reviewed
Dec 27, 2023
| @@ -41,21 +41,29 @@ import scala.util.control.NoStackTrace | |||
| * The same implementation is also be found as part of the 'scripted' tests at | |||
| * /sbt-plugin/src/sbt-test/gen-scala-server/00-interop/src/test/scala/org/apache/pekko/grpc/PekkoGrpcClientTester.scala | |||
| */ | |||
| class PekkoGrpcScalaClientTester(val settings: Settings, backend: String)(implicit system: ActorSystem) | |||
| extends ClientTester { | |||
| class PekkoGrpcScalaClientTester(val settings: Settings, backend: String, testWithSslContext: Boolean)( | |||
There was a problem hiding this comment.
maybe better with a trait
SslContextProvider, and the false can be expressed by returning None.
There was a problem hiding this comment.
It is test code. And the SSL context is created inside this class. Not outside.
There was a problem hiding this comment.
When we have a use case for creating the SSL context outside - we can change then. Seems bad to overengineer test code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new tests in GrpcInteropIoWithPekkoNettyScalaWithSslContextSpec fail without the fix in #199