Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt-pekko-build to 0.3.1 #213

Merged
merged 1 commit into from
Jan 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import sbt.Keys.scalaVersion

// pekkoInlineEnabled should be set to true when we start building 1.1.x builds
ThisBuild / pekkoInlineEnabled := false
ThisBuild / apacheSonatypeProjectProfile := "pekko"
sourceDistName := "apache-pekko-grpc"
sourceDistIncubating := true
ThisBuild / versionScheme := Some(VersionScheme.SemVerSpec)
Expand Down
2 changes: 1 addition & 1 deletion gradle-plugin/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ gradlePlugin {
publishing {
publications.withType(MavenPublication) {
pom {
name = "pekko-grpc-gradle-plugin"
name = "Apache Pekko Grpc Gradle Plugin"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a maven plugin too

Copy link
Contributor Author

@mdedetrich mdedetrich Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a maven plugin too

Yes but the maven plugin is generated by sbt so the name will also be fixed by the updated sbt-apache-sonatype (you can check yourself, there is no pom.xml in the maven plugin). Its only gradle that is the exception here.

description = "Apache Pekko gRPC - Support for building streaming gRPC servers and clients on top of Pekko Streams."
url = "https://pekko.apache.org/"
licenses {
Expand Down
3 changes: 1 addition & 2 deletions project/plugins.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "1.1.3")
addSbtPlugin("net.bzzt" % "sbt-reproducible-builds" % "0.31")
addSbtPlugin("pl.project13.scala" % "sbt-jmh" % "0.4.3")
addSbtPlugin("com.dwijnand" % "sbt-dynver" % "4.1.1")
addSbtPlugin("org.mdedetrich" % "sbt-apache-sonatype" % "0.1.10")
addSbtPlugin("com.github.pjfanning" % "sbt-pekko-build" % "0.3.0")
addSbtPlugin("com.github.pjfanning" % "sbt-pekko-build" % "0.3.1")
addSbtPlugin("com.github.pjfanning" % "sbt-source-dist" % "0.1.11")
addSbtPlugin("com.github.sbt" % "sbt-license-report" % "1.6.1")

Expand Down