Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add javafmt plugin #260

Merged
merged 4 commits into from
Apr 6, 2024
Merged

Add javafmt plugin #260

merged 4 commits into from
Apr 6, 2024

Conversation

laglangyue
Copy link
Contributor

motivation

close #258

changs

Refer to the settings in pekko-http

  • add plugin to plugin.sbt
  • execute execute sbt javafmtAll

@laglangyue
Copy link
Contributor Author

It's strange, just format, but cause a NPE in init class. I attempt to reproduce exception in my pc, and test it ok.

He-Pin
He-Pin approved these changes Apr 6, 2024
View reviewed changes
Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 7783170 into apache:main Apr 6, 2024
19 checks passed
@pjfanning
Copy link
Contributor

merged - thanks

@pjfanning pjfanning mentioned this pull request Apr 6, 2024
Merged
@laglangyue laglangyue deleted the add-java-fmt branch April 7, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@He-Pin He-Pin He-Pin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add javafmt-plugin
3 participants
@laglangyue @pjfanning @He-Pin