Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guava to 32.1.2-jre #269

Closed
wants to merge 2 commits into from
Closed

Conversation

scala-steward-asf[bot]
Copy link
Contributor

About this PR

πŸ“¦ Updates com.google.guava:guava from 32.1.2-android to 32.1.2-jre

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

πŸ” Files still referring to the old version number

The following files still refer to the old version number (32.1.2-android).
You might want to review and update them manually.

gradle-plugin/build.gradle
βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.google.guava", artifactId = "guava" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.google.guava", artifactId = "guava" }
}]
labels: library-update, early-semver-pre-release, semver-spec-pre-release, old-version-remains, commit-count:1

@github-actions github-actions bot added the update label Apr 6, 2024
@raboof
Copy link
Member

raboof commented Apr 6, 2024

@pjfanning did you have a reason to depend on guava-android instead of guava-jre in 9fad037 ?

@pjfanning
Copy link
Contributor

one of our dependencies prefers the android version of guava

now that we have upgraded dependencies, we can stop forcing guava ourselves and just rely on the transitive dependency

@pjfanning
Copy link
Contributor

I've created #279

@pjfanning pjfanning closed this Apr 6, 2024
@pjfanning pjfanning deleted the update/guava-32.1.2-jre branch April 6, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants