Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpc-core, grpc-interop-testing, ... to 1.63.0 #271

Closed
wants to merge 2 commits into from

Conversation

scala-steward-asf[bot]
Copy link
Contributor

About this PR

📦 Updates

from 1.62.2 to 1.63.0

📜 GitHub Release Notes - Version Diff

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

🔍 Files still referring to the old version number

The following files still refer to the old version number (1.62.2).
You might want to review and update them manually.

gradle-plugin/src/main/groovy/org/apache/pekko/grpc/gradle/PekkoGrpcPluginExtension.groovy
⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "io.grpc" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "io.grpc" }
}]
labels: library-update, early-semver-minor, semver-spec-minor, old-version-remains, commit-count:1

@github-actions github-actions bot added the update label Apr 6, 2024
@raboof raboof self-assigned this Apr 6, 2024
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to manually update PekkoGrpcPluginExtension.groovy, now LGTM

@pjfanning pjfanning force-pushed the update/grpc-core-1.63.0 branch from 48de072 to fe5858f Compare April 6, 2024 17:58
@raboof
Copy link
Member

raboof commented Apr 6, 2024

The failing test looks legitimate: it's should eventually fail when no valid endpoints are provided in org.apache.pekko.grpc.scaladsl.NonBalancingIntegrationSpecNetty in interop-tests.

You can run this test individually in sbt with project interop-tests; testOnly *NonBalancingIntegrationSpecNetty -- -z "eventually". Looking into it.

@raboof
Copy link
Member

raboof commented Apr 6, 2024

OK, so 1.63.0 switches the default io.grpc loadbalancer from PickFirstLoadBalancer to PickFirstLeafLoadBalancer, which does not report transient errors the way PickFirstLoadBalancer used to.

Indeed, setting GRPC_EXPERIMENTAL_ENABLE_NEW_PICK_FIRST to false makes the test succeed again under 1.63.0, and setting it to true makes it fail even on main (still on 1.62.2).

Filed grpc/grpc-java#11082 - let's hold off on updating for now and decide how to move forward based on feedback there.

raboof added a commit to raboof/incubator-pekko-grpc that referenced this pull request Apr 6, 2024
@raboof raboof mentioned this pull request Apr 6, 2024
raboof added a commit that referenced this pull request Apr 7, 2024
@pjfanning pjfanning closed this Apr 7, 2024
@pjfanning pjfanning deleted the update/grpc-core-1.63.0 branch April 7, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants