fix flaky failure in CI for RichErrorModelTest #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
reviewed
Apr 13, 2024
| @@ -94,6 +92,8 @@ public void testManualApproach() throws Exception { | |||
| } finally { | |||
| if (client != null) client.close(); | |||
| sys.terminate(); | |||
| serverBinding.unbind(); | |||
There was a problem hiding this comment.
should we waiting on the unbind future too?
He-Pin
reviewed
Apr 13, 2024
| @@ -52,8 +53,7 @@ private CompletionStage<ServerBinding> run(ActorSystem sys) throws Exception { | |||
| public void testManualApproach() throws Exception { | |||
| Config conf = ConfigFactory.load(); | |||
| ActorSystem sys = ActorSystem.create("HelloWorld", conf); | |||
| run(sys); | |||
|
|
|||
| ServerBinding serverBinding = run(sys).toCompletableFuture().get(60, TimeUnit.SECONDS); | |||
There was a problem hiding this comment.
agree, but it's a timeout, so it's no problem if it's a little generous
raboof
approved these changes
Apr 13, 2024
| @@ -52,8 +53,7 @@ private CompletionStage<ServerBinding> run(ActorSystem sys) throws Exception { | |||
| public void testManualApproach() throws Exception { | |||
| Config conf = ConfigFactory.load(); | |||
| ActorSystem sys = ActorSystem.create("HelloWorld", conf); | |||
| run(sys); | |||
|
|
|||
| ServerBinding serverBinding = run(sys).toCompletableFuture().get(60, TimeUnit.SECONDS); | |||
There was a problem hiding this comment.
agree, but it's a timeout, so it's no problem if it's a little generous
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation
close #291
client should wait http server start, and need to stop http finally.
how
add wait and stop