Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate a frequently flaky CI failure in GrpcExceptionHandlerSpec #293

Merged
merged 2 commits into from
Apr 13, 2024
Merged

Investigate a frequently flaky CI failure in GrpcExceptionHandlerSpec #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
878fe52
Investigate a frequently flaky CI failure in GrpcExceptionHandlerSpec
laglangyue Apr 13, 2024
26035a4
update doc
laglangyue Apr 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/src/main/paradox/server/details.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,15 @@ For an overview of gRPC status codes and their meaning see [statuscodes.md](http
For unary responses:

Scala
: @@snip[GrpcExceptionHandlerSpec](/interop-tests/src/test/scala/org/apache/pekko/grpc/scaladsl/GrpcExceptionHandlerSpec.scala) { #unary }
: @@snip[GrpcExceptionDefaultHandleSpec](/interop-tests/src/test/scala/org/apache/pekko/grpc/scaladsl/GrpcExceptionDefaultHandleSpec.scala) { #unary }

Java
: @@snip[ExceptionGreeterServiceImpl](/interop-tests/src/test/java/example/myapp/helloworld/grpc/ExceptionGreeterServiceImpl.java) { #unary }

For streaming responses:

Scala
: @@snip[GrpcExceptionHandlerSpec](/interop-tests/src/test/scala/org/apache/pekko/grpc/scaladsl/GrpcExceptionHandlerSpec.scala) { #streaming }
: @@snip[GrpcExceptionDefaultHandleSpec](/interop-tests/src/test/scala/org/apache/pekko/grpc/scaladsl/GrpcExceptionDefaultHandleSpec.scala) { #streaming }

Java
: @@snip[ExceptionGreeterServiceImpl](/interop-tests/src/test/java/example/myapp/helloworld/grpc/ExceptionGreeterServiceImpl.java) { #streaming }
Expand Down
4 changes: 2 additions & 2 deletions ...c/scaladsl/GrpcExceptionHandlerSpec.scala → ...adsl/GrpcExceptionDefaultHandleSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ import org.scalatest.wordspec.AnyWordSpecLike

import scala.concurrent.{ ExecutionContext, Future }

class GrpcExceptionHandlerSpec
extends TestKit(ActorSystem("GrpcExceptionHandlerSpec"))
class GrpcExceptionDefaultHandleSpec
extends TestKit(ActorSystem("GrpcExceptionDefaultHandleSpec"))
with AnyWordSpecLike
with Matchers
with ScalaFutures {
Expand Down
8 changes: 4 additions & 4 deletions runtime/src/test/scala/org/apache/pekko/grpc/scaladsl/GrpcExceptionHandlerSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@ class GrpcExceptionHandlerSpec extends AnyWordSpec with Matchers with ScalaFutur

val otherTypes: Seq[Throwable] = Seq(
new GrpcServiceException(status = Status.DEADLINE_EXCEEDED),
new NotImplementedError,
new UnsupportedOperationException,
new NullPointerException,
new RuntimeException,
new NotImplementedError(),
new UnsupportedOperationException(),
new NullPointerException(),
new RuntimeException(),
new StatusRuntimeException(io.grpc.Status.DEADLINE_EXCEEDED))

val executionExceptions: Seq[Throwable] =
Expand Down
Loading