Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test with latest scala releases #134

Merged
merged 1 commit into from
Oct 31, 2023
Merged

test with latest scala releases #134

merged 1 commit into from
Oct 31, 2023

Conversation

pjfanning
Copy link
Contributor

  • also sbt 1.9.7
  • sbt plugin updates

@pjfanning pjfanning requested review from mdedetrich, nvollmar and He-Pin and removed request for mdedetrich October 31, 2023 15:53
nvollmar
nvollmar approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@nvollmar nvollmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 505215d into apache:main Oct 31, 2023
13 of 14 checks passed
@pjfanning pjfanning deleted the upgrade-scala branch October 31, 2023 16:19
@mdedetrich
Copy link
Contributor

@pjfanning I think this PR will break the github actions, you need to modify the sbt command to accept just major + minor, no?

@pjfanning
Copy link
Contributor Author

@mdedetrich I merged this before your comment. The unit tests passed in the PR CI run. The unit test yml had a similar change to the nightly yml and the unit tests ran ok (1 intermittent test failed in Scala 3 run).

I've started a nightly test run just in case and if that fails, I'll submit a revert or fix.

There is an open issue for the nightly tests - #132

@pjfanning
Copy link
Contributor Author

@mdedetrich nightly run (forced to run by me just now) was ok. It had the expected test failures but scala version wasn't an issue.

expected test failures described in #132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvollmar nvollmar nvollmar approved these changes

@He-Pin He-Pin Awaiting requested review from He-Pin

@mdedetrich mdedetrich Awaiting requested review from mdedetrich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pjfanning @mdedetrich @nvollmar