Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back performance change to loadCertificates #155

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Add back performance change to loadCertificates #155

merged 1 commit into from
Mar 26, 2024

Conversation

pjfanning
Copy link
Contributor

Reverts #153

@pjfanning pjfanning added this to the 1.1.0 milestone Jan 21, 2024
@pjfanning pjfanning marked this pull request as draft January 21, 2024 21:19
@mdedetrich
Copy link
Contributor

@pjfanning You can change the PR from draft if you want, its just that we shouldn't merge it now (thats all)

nvollmar
nvollmar approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@nvollmar nvollmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning changed the title Revert "Revert "performance change to loadCertificates"" Add back performance change to loadCertificates Jan 22, 2024
@pjfanning pjfanning marked this pull request as ready for review March 26, 2024 12:13
@pjfanning pjfanning merged commit 23ad5ef into main Mar 26, 2024
16 checks passed
@pjfanning pjfanning deleted the revert-153-revert-152-pem-reader branch March 26, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvollmar nvollmar nvollmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0-M1
Development

Successfully merging this pull request may close these issues.
3 participants
@pjfanning @mdedetrich @nvollmar