jackson 2.18 with max-token-count support #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pjfanning
commented
Nov 9, 2024
•
pjfanning
commented
- supports Fix #1310: Count JSON tokens FasterXML/jackson-core#1296
- Jackson lock-free buffer recyclers turned out to have major trouble and have been deprecated - Jackson LockFreePool recycler pool causes memory issues trinodb/trino#21356
pjfanning
changed the title
He-Pin
reviewed
Dec 28, 2024
| @@ -159,11 +160,10 @@ object JacksonObjectMapperProvider extends ExtensionId[JacksonObjectMapperProvid | |||
| private def getBufferRecyclerPool(cfg: Config): RecyclerPool[BufferRecycler] = { | |||
| cfg.getString("buffer-recycler.pool-instance") match { | |||
| case "thread-local" => JsonRecyclerPools.threadLocalPool() | |||
| case "lock-free" => JsonRecyclerPools.newLockFreePool() | |||
| case "shared-lock-free" => JsonRecyclerPools.sharedLockFreePool() | |||
There was a problem hiding this comment.
So there is been removed and should we mention that in the release note?
There was a problem hiding this comment.
yes - support was removed from Jackson for these because they did not work
He-Pin
approved these changes
Dec 28, 2024
|
We add release notes for every release. Generally, they are created around release time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.