feat: Add TraversalBuilder.getValuePresentedSource method for further optimization #1701
+140
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
commented
Jan 10, 2025
| @@ -23,7 +23,7 @@ import java.util.function.Consumer | |||
|
|
|||
| /** INTERNAL API */ | |||
| @InternalApi private[stream] final class JavaStreamSource[T, S <: java.util.stream.BaseStream[T, S]]( | |||
| open: () => java.util.stream.BaseStream[T, S]) | |||
| val open: () => java.util.stream.BaseStream[T, S]) | |||
He-Pin
commented
Jan 10, 2025
| @@ -22,7 +22,7 @@ import pekko.stream.stage.{ GraphStage, GraphStageLogic, OutHandler } | |||
| /** | |||
| * INTERNAL API | |||
| */ | |||
| @InternalApi private[pekko] final class FailedSource[T](failure: Throwable) extends GraphStage[SourceShape[T]] { | |||
| @InternalApi private[pekko] final class FailedSource[T](val failure: Throwable) extends GraphStage[SourceShape[T]] { | |||
He-Pin
force-pushed
the
getValuePresentedSource
branch
from
684155c to
0735893
Compare
pjfanning
reviewed
Jan 10, 2025
stream/src/main/scala/org/apache/pekko/stream/impl/TraversalBuilder.scala
Outdated
Show resolved
Hide resolved
He-Pin
commented
Jan 10, 2025
stream-tests/src/test/scala/org/apache/pekko/stream/impl/TraversalBuilderSpec.scala
Show resolved
Hide resolved
He-Pin
force-pushed
the
getValuePresentedSource
branch
from
0735893 to
5ee21b8
Compare
|
After this pr get merged, we can do some optimization for |
|
@pjfanning @raboof Would you like to help review this? |
He-Pin
force-pushed
the
getValuePresentedSource
branch
2 times, most recently
from
bfbfe06 to
01de9bb
Compare
He-Pin
force-pushed
the
getValuePresentedSource
branch
from
01de9bb to
041a74a
Compare
|
@pjfanning I have rebased on the current main. @mdedetrich @Roiocam Would you like to take a look too? |
|
I think this looks ok but I would prefer to see some more reviews but it gets merged. |
|
Yeah, really hope we get more reviewer:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Add helper method to extract the value presented graph which will enable future optimization.
which is needed in #1672
Modification:
Add TraversalBuilder.getValuePresentedSource method
Result:
TraversalBuilder.getValuePresentedSource internal method added