Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section on using scala3 union types #695

Merged
merged 4 commits into from
Oct 11, 2023

Conversation

eloots
Copy link
Contributor

@eloots eloots commented Oct 3, 2023

Draft for doc update regarding the utilisation of Scala 3 Union types to eliminate message adapters & wrappers.

Would certainly appreciate feedback from @pjfanning and @He-Pin

@pjfanning
Copy link
Contributor

@eloots Looks like this is on the right track. I can have a closer look in a day or 2.

Would you have interest in creating a PR to backport your original PR (with the example) to the 1.0.x branch. We can also backport this PR when it is ready - meaning that the 1.0.x docs can be updated to include this.

@eloots
Copy link
Contributor Author

eloots commented Oct 3, 2023

Would you have interest in creating a PR to backport your original PR

Certainly!

He-Pin

This comment was marked as duplicate.

- Point out that Union types are Scala 3 specific
@He-Pin
Copy link
Member

He-Pin commented Oct 11, 2023

Thanks , a nice reading~

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@He-Pin He-Pin merged commit 0a09ccc into apache:main Oct 11, 2023
@eloots
Copy link
Contributor Author

eloots commented Oct 16, 2023

@pjfanning @He-Pin

We can also backport this PR when it is ready - meaning that the 1.0.x docs can be updated to include this.

I just created #741 with the backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants