Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark function tail recursive #780

Merged
merged 1 commit into from
Nov 6, 2023
Merged

mark function tail recursive #780

merged 1 commit into from
Nov 6, 2023

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Nov 6, 2023 •
edited
Loading

saw a compiler warning about it

mdedetrich
mdedetrich approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 99b4df3 into apache:main Nov 6, 2023
18 checks passed
@pjfanning pjfanning deleted the tailrec branch November 6, 2023 23:21
pjfanning added a commit to pjfanning/incubator-pekko that referenced this pull request Nov 6, 2023
@pjfanning
mark function tail recursive (apache#780)
a9ff8e8
pjfanning added a commit that referenced this pull request Nov 7, 2023
@pjfanning
mark function tail recursive (#780) (#781)
e3335d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdedetrich mdedetrich mdedetrich approved these changes

@He-Pin He-Pin Awaiting requested review from He-Pin

@nvollmar nvollmar Awaiting requested review from nvollmar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjfanning @mdedetrich