-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scala3.md #804
Update scala3.md #804
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bit about CrossVersion.for3Use2_13
should be entirely removed as we shouldn't be encouraging it, otherwise lgtm.
|
||
## Using 2.13 artifacts in Scala 3 | ||
|
||
You can use [CrossVersion.for3Use2_13](https://scala-lang.org/blog/2021/04/08/scala-3-in-sbt.html#using-scala-213-libraries-in-scala-3) | ||
This should not be necessary but you can use [CrossVersion.for3Use2_13](https://scala-lang.org/blog/2021/04/08/scala-3-in-sbt.html#using-scala-213-libraries-in-scala-3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove this paragraph entirely, you should only be using the Scala 3 artifacts and considering we are using LTS there shouldn't be an issue here. Also its ideal to not have multiple ways of supporting Scala 3, just use the Scala 3 artifacts. Using CrossVersion.for3Use2_13
was mainly a clutch in the past when Scala 3 was not available or we were using experimental/non LTS versions of Scala 3.
Also CrossVersion.for3Use2_13
cannot be used if you are a library that depends on Pekko, it only works with applications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed after the suggested changes, looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* Update scala3.md * Update scala3.md * Update scala3.md
This page seems badly out of date.