addresses PR comment

apache · Dec 18, 2024 · 903d519 · 903d519
1 parent cc70645
commit 903d519
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...n/src/main/java/org/apache/pinot/common/minion/RealtimeToOfflineSegmentsTaskMetadata.java b/...n/src/main/java/org/apache/pinot/common/minion/RealtimeToOfflineSegmentsTaskMetadata.java
@@ -54,7 +54,7 @@
  */
 public class RealtimeToOfflineSegmentsTaskMetadata extends BaseTaskMetadata {
 
-  private static final String WINDOW_START_KEY = "windowStartMs";
+  private static final String WINDOW_START_KEY = "watermarkMs";
   private static final String WINDOW_END_KEY = "windowEndMs";
   private static final String COMMA_SEPARATOR = ",";
   private static final String SEGMENT_NAME_VS_EXPECTED_RTO_RESULT_ID_KEY = "segmentVsExpectedRTOResultId";

diff --git a/...test/java/org/apache/pinot/common/metadata/RealtimeToOfflineSegmentsTaskMetadataTest.java b/...test/java/org/apache/pinot/common/metadata/RealtimeToOfflineSegmentsTaskMetadataTest.java
@@ -43,7 +43,7 @@ public void testToFromZNRecord() {
         new RealtimeToOfflineSegmentsTaskMetadata("testTable_REALTIME", 1000);
     ZNRecord znRecord = metadata.toZNRecord();
     assertEquals(znRecord.getId(), "testTable_REALTIME");
-    assertEquals(znRecord.getSimpleField("windowStartMs"), "1000");
+    assertEquals(znRecord.getSimpleField("watermarkMs"), "1000");
 
     RealtimeToOfflineSegmentsTaskMetadata realtimeToOfflineSegmentsTaskMetadata =
         RealtimeToOfflineSegmentsTaskMetadata.fromZNRecord(znRecord);
@@ -83,7 +83,7 @@ public void testToFromZNRecordWithWindowIntervalAndExpectedResults() {
 
     ZNRecord znRecord = originalMetadata.toZNRecord();
     assertEquals(znRecord.getId(), "testTable_REALTIME");
-    assertEquals(znRecord.getSimpleField("windowStartMs"), "1000");
+    assertEquals(znRecord.getSimpleField("watermarkMs"), "1000");
     assertEquals(znRecord.getSimpleField("windowEndMs"), "2000");
     Map<String, List<String>> listFields = znRecord.getListFields();
     Map<String, Map<String, String>> mapFields = znRecord.getMapFields();