Upgraded clp-ffi.version from 0.4.5 to 0.4.7 #14242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14242 +/- ##
============================================
+ Coverage 61.75% 63.84% +2.09%
- Complexity 207 1535 +1328
============================================
Files 2436 2623 +187
Lines 133233 144441 +11208
Branches 20636 22103 +1467
============================================
+ Hits 82274 92215 +9941
- Misses 44911 45419 +508
- Partials 6048 6807 +759
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
clp-ffilibrary version was automatically updated from0.4.5to0.4.6via a Dependabot-generated PR. However, this introduced a data race issue due to improper initialization of a thread-local variable. In PR #14230, the version bump was reverted to address the problem. The bug in 0.4.6 has since been resolved in the latest release (0.4.7). This PR upgrades theclp-ffito the latest version to be used by dependent PR such as #14241.