Speed up BinaryOperatorTransformFunction evaluation to use PredicateEvaluator #14619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
force-pushed
the
BinaryOperatorTransformFunction-optimization
branch
from
377045c to
eaf6a9d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14619 +/- ##
============================================
+ Coverage 61.75% 64.00% +2.25%
- Complexity 207 1605 +1398
============================================
Files 2436 2700 +264
Lines 133233 148938 +15705
Branches 20636 22845 +2209
============================================
+ Hits 82274 95331 +13057
- Misses 44911 46612 +1701
- Partials 6048 6995 +947
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
force-pushed
the
BinaryOperatorTransformFunction-optimization
branch
4 times, most recently
from
9778fbb to
5164df3
Compare
.../java/org/apache/pinot/core/operator/transform/function/BinaryOperatorTransformFunction.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/pinot/core/operator/transform/function/BinaryOperatorTransformFunction.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
BinaryOperatorTransformFunction-optimization
branch
3 times, most recently
from
fc21c88 to
ff991bf
Compare
xiangfu0
force-pushed
the
BinaryOperatorTransformFunction-optimization
branch
3 times, most recently
from
1a1bc83 to
9e0a4d7
Compare
xiangfu0
force-pushed
the
BinaryOperatorTransformFunction-optimization
branch
from
9e0a4d7 to
c2c2707
Compare
xiangfu0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For BinaryOperatorTransformFunction, we don't need to read the values then compare but use dictionary.
Further optimization could be using predicate evaluator.