Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip optimizing IN predicate when it contains too many values #14670

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jackie-Jiang
Copy link
Contributor

MergeEqInFilterOptimizer maintains a set of thrift Expression for IN predicate values. It is very expensive to calculate hash code for Expression, thus we limit the values allowed to apply the optimizer

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.99%. Comparing base (59551e4) to head (22f16b0).
Report is 1483 commits behind head on master.

Files with missing lines Patch % Lines
...ery/optimizer/filter/MergeEqInFilterOptimizer.java 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14670      +/-   ##
============================================
+ Coverage     61.75%   63.99%   +2.24%     
- Complexity      207     1604    +1397     
============================================
  Files          2436     2703     +267     
  Lines        133233   148926   +15693     
  Branches      20636    22820    +2184     
============================================
+ Hits          82274    95310   +13036     
- Misses        44911    46627    +1716     
- Partials       6048     6989     +941     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.95% <57.14%> (+2.24%) ⬆️
java-21 63.89% <57.14%> (+2.26%) ⬆️
skip-bytebuffers-false 63.99% <57.14%> (+2.24%) ⬆️
skip-bytebuffers-true 63.85% <57.14%> (+36.12%) ⬆️
temurin 63.99% <57.14%> (+2.24%) ⬆️
unittests 63.99% <57.14%> (+2.24%) ⬆️
unittests1 56.31% <57.14%> (+9.42%) ⬆️
unittests2 34.42% <28.57%> (+6.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants