Extend to add Default Server level configs for Dedup Tables #14684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge master
deepthi912
commented
Dec 19, 2024
| @@ -96,4 +96,10 @@ public String getDedupTimeColumn() { | |||
| public boolean isEnablePreload() { | |||
| return _enablePreload; | |||
| } | |||
|
|
|||
| // CHECKSTYLE:OFF | |||
There was a problem hiding this comment.
Switched off the checkstyle as we would need to set server configs for preload when extending.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14684 +/- ##
============================================
+ Coverage 61.75% 64.07% +2.32%
- Complexity 207 1608 +1401
============================================
Files 2436 2706 +270
Lines 133233 149093 +15860
Branches 20636 22844 +2208
============================================
+ Hits 82274 95534 +13260
- Misses 44911 46554 +1643
- Partials 6048 7005 +957
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
merge master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following config settings are added in the PR on server level to extend the default behaviour of dedup: