Expose msg length info to metadata #14688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itschrispeck
approved these changes
Dec 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14688 +/- ##
============================================
+ Coverage 61.75% 64.00% +2.25%
- Complexity 207 1608 +1401
============================================
Files 2436 2706 +270
Lines 133233 149161 +15928
Branches 20636 22861 +2225
============================================
+ Hits 82274 95472 +13198
- Misses 44911 46689 +1778
- Partials 6048 7000 +952
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
approved these changes
Dec 20, 2024
| @@ -30,6 +30,7 @@ public class StreamDataDecoderImpl implements StreamDataDecoder { | |||
| public static final String KEY = "__key"; | |||
| public static final String HEADER_KEY_PREFIX = "__header$"; | |||
| public static final String METADATA_KEY_PREFIX = "__metadata$"; | |||
| public static final String RECORD_SERIALIZED_VALUE_SIZE_KEY = "recordSerializedValueSize"; | |||
There was a problem hiding this comment.
Suggest naming it METADATA_KEY_PREFIX + "streamMessageSize" to be more specific. We can have it with prefix to avoid always concating them
zeronerdzerogeekzerocool
pushed a commit
to zeronerdzerogeekzerocool/pinot
that referenced
this pull request
Feb 20, 2025
* Expose msg length info to metadata * Address comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
featureStream message length is an important metadata information as its timestamp. Expose this info to metadata to make it easier extracted through transform functions.