Allow periodic tasks to run with properties via the POST API #14915
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14915 +/- ##
============================================
+ Coverage 61.75% 63.71% +1.96%
- Complexity 207 1470 +1263
============================================
Files 2436 2708 +272
Lines 133233 151565 +18332
Branches 20636 23404 +2768
============================================
+ Hits 82274 96567 +14293
- Misses 44911 47745 +2834
- Partials 6048 7253 +1205
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @Authorize(targetType = TargetType.CLUSTER, action = Actions.Cluster.EXECUTE_TASK) | ||
| @ApiOperation(value = "Run periodic task against table with custom properties. If table name is missing, task will " | ||
| + "run against all tables.") | ||
| public Response runPeriodicTaskWithProperties( |
There was a problem hiding this comment.
Why a new method? Are we not able to just add param to existing method without breaking backward compatibility?
There was a problem hiding this comment.
I did not want to keep it as a query param for the GET API.
Passing Map/ API param in a GET request also looks a bit weird (against HTTP standards). That's why introduced POST with API params.
POST API:
Running segment level validaitons in RealtimeSegmentValidationManager
Local Testing:
The segment level validations run even when the time constraints are not met.
