Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker compose & quick start #5178

Merged
merged 2 commits into from
Mar 24, 2020
Merged

Fix docker compose & quick start #5178

merged 2 commits into from
Mar 24, 2020

Conversation

konradmalik
Copy link
Contributor

Quick start for docker does not currently work.

  1. default network created by compose starts with the name of the parent dir. So it is "pinot_default", not "docker_default". Scripts in README were fixed according to that.
  2. docker-compose -f docker-compose up does not start the stack properly. Services complain about connectivity issues, which trace back to zookeeper. Turns out (probably a change in the newer version, as docker-compose users "latest" tag) ZOO_SERVERS need a listening port at the end. This is also now fixed.

Now users can simply follow Quick Start instructions and all will work "out of the box".

Copy link
Member

@kishoreg kishoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. Let us wait for @fx19880617 to review as well.

@codecov-io
Copy link

Codecov Report

Merging #5178 into master will increase coverage by 9.50%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5178      +/-   ##
============================================
+ Coverage     56.52%   66.03%   +9.50%     
  Complexity       12       12              
============================================
  Files          1052     1052              
  Lines         54170    54170              
  Branches       8078     8078              
============================================
+ Hits          30620    35771    +5151     
+ Misses        21118    15738    -5380     
- Partials       2432     2661     +229     
Impacted Files Coverage Δ Complexity Δ
...pache/pinot/core/util/SortedRangeIntersection.java 83.82% <0.00%> (-7.36%) 0.00% <0.00%> (ø%)
.../realtime/impl/ThreadSafeMutableRoaringBitmap.java 92.85% <0.00%> (-7.15%) 0.00% <0.00%> (ø%)
...l/FixedByteSingleColumnMultiValueReaderWriter.java 68.91% <0.00%> (-2.08%) 0.00% <0.00%> (ø%)
.../java/org/apache/pinot/spi/data/TimeFieldSpec.java 92.59% <0.00%> (-1.24%) 0.00% <0.00%> (ø%)
...pql/parsers/PinotQuery2BrokerRequestConverter.java 88.07% <0.00%> (+0.45%) 0.00% <0.00%> (ø%)
...ment/creator/impl/SegmentColumnarIndexCreator.java 88.25% <0.00%> (+0.75%) 0.00% <0.00%> (ø%)
.../helix/core/realtime/SegmentCompletionManager.java 70.63% <0.00%> (+0.85%) 0.00% <0.00%> (ø%)
...java/org/apache/pinot/common/utils/DataSchema.java 85.29% <0.00%> (+0.98%) 0.00% <0.00%> (ø%)
.../FixedByteSingleColumnSingleValueReaderWriter.java 98.94% <0.00%> (+1.05%) 0.00% <0.00%> (ø%)
...t/common/response/broker/BrokerResponseNative.java 90.52% <0.00%> (+1.05%) 0.00% <0.00%> (ø%)
... and 317 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ed426...449d470. Read the comment docs.

@xiangfu0 xiangfu0 merged commit 4a6b21d into apache:master Mar 24, 2020
@xiangfu0
Copy link
Contributor

Thanks for fixing this!

@konradmalik konradmalik deleted the fix-docker-compose branch April 14, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants