refine int cast long #348
Open
refine int cast long #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
applied some of these changes - rebase and see if you want to get the rest merged |
XenoAmess
force-pushed
the
refine_int_cast_long
branch
from
450c2b7 to
f581825
Compare
pjfanning
reviewed
Jul 17, 2022
| @@ -185,7 +185,7 @@ void test62872() throws Exception { | |||
| cell = row.createCell(j - 1); | |||
|
|
|||
| //make some noise | |||
| cell.setCellValue(new Date(i * TEN_MINUTES + (j * TEN_MINUTES) / COLUMN_COUNT)); | |||
| cell.setCellValue(new Date((long) i * TEN_MINUTES + (j * TEN_MINUTES) / COLUMN_COUNT)); | |||
There was a problem hiding this comment.
this is test code - not worth changing
pjfanning
reviewed
Jul 17, 2022
| @@ -29,7 +29,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more | |||
| public final class Notes extends SheetContainer | |||
| { | |||
| private byte[] _header; | |||
| private static long _type = 1008l; | |||
| private static long _type = 1008L; | |||
There was a problem hiding this comment.
why change the l to an L?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.