Fix create view failure (#216)

apache · Sep 12, 2024 · 4c2a449 · 4c2a449
1 parent 6818d35
commit 4c2a449
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java b/polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java
@@ -1164,6 +1164,9 @@ private class BasePolarisCatalogViewBuilder extends BaseMetastoreViewCatalog.Bas
 
     public BasePolarisCatalogViewBuilder(TableIdentifier identifier) {
       super(identifier);
+      withProperties(
+          PropertyUtil.propertiesWithPrefix(
+              BasePolarisCatalog.this.properties(), "table-default."));
     }
 
     @Override

diff --git a/...service/src/test/java/org/apache/polaris/service/catalog/PolarisSparkIntegrationTest.java b/...service/src/test/java/org/apache/polaris/service/catalog/PolarisSparkIntegrationTest.java
@@ -240,6 +240,10 @@ private void cleanupCatalog(String catalogName) {
       for (Row table : tables) {
         onSpark("DROP TABLE " + namespace.getString(0) + "." + table.getString(1));
       }
+      List<Row> views = onSpark("SHOW VIEWS IN " + namespace.getString(0)).collectAsList();
+      for (Row view : views) {
+        onSpark("DROP VIEW " + namespace.getString(0) + "." + view.getString(1));
+      }
       onSpark("DROP NAMESPACE " + namespace.getString(0));
     }
     try (Response response =
@@ -351,6 +355,20 @@ public void testCreateAndUpdateExternalTable() {
     assertThat(rowCount).isEqualTo(4);
   }
 
+  @Test
+  public void testCreateView() {
+    long namespaceCount = onSpark("SHOW NAMESPACES").count();
+    assertThat(namespaceCount).isEqualTo(0L);
+
+    onSpark("CREATE NAMESPACE ns1");
+    onSpark("USE ns1");
+    onSpark("CREATE TABLE tb1 (col1 integer, col2 string)");
+    onSpark("INSERT INTO tb1 VALUES (1, 'a'), (2, 'b'), (3, 'c')");
+    onSpark("CREATE VIEW view1 AS SELECT * FROM tb1");
+    long recordCount = onSpark("SELECT * FROM view1").count();
+    assertThat(recordCount).isEqualTo(3);
+  }
+
   private LoadTableResponse loadTable(String catalog, String namespace, String table) {
     try (Response response =
         EXT.client()