Skip to content

Commit

Permalink
Add comment to TransactionWorkspaceMetaStoreManager regarding plans f…
Browse files Browse the repository at this point in the history
…or more advanced transactions,

and fix formatting.
  • Loading branch information
dennishuo committed Sep 18, 2024
1 parent 36d2833 commit 6502ee6
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,13 @@
public class TransactionWorkspaceMetaStoreManager implements PolarisMetaStoreManager {
private final PolarisMetaStoreManager delegate;

// TODO: If we want to support the semantic of opening a transaction in which multiple
// reads and writes occur on the same entities, where the reads are expected to see the writes
// within the transaction workspace that haven't actually been committed, we can augment this
// class by allowing these pendingUpdates to represent the latest state of the entity if we
// also increment entityVersion. We'd need to store both a "latest view" of all updated entities
// to serve reads within the same transaction while also storing the ordered list of
// pendingUpdates that ultimately need to be applied in order within the real MetaStoreManager.
private final List<EntityWithPath> pendingUpdates = new ArrayList<>();

public TransactionWorkspaceMetaStoreManager(PolarisMetaStoreManager delegate) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
import org.apache.iceberg.catalog.SessionCatalog;
import org.apache.iceberg.catalog.TableCommit;
import org.apache.iceberg.catalog.TableIdentifier;
import org.apache.iceberg.exceptions.BadRequestException;
import org.apache.iceberg.exceptions.CommitFailedException;
import org.apache.iceberg.exceptions.ForbiddenException;
import org.apache.iceberg.expressions.Expressions;
Expand Down

0 comments on commit 6502ee6

Please sign in to comment.