Revert "Copy RealmId when passing it to TaskExecutorImpl (#879)"

This reverts commit febe4e8.
apache · Jan 31, 2025 · 8fff253 · 8fff253
1 parent 569bf02
commit 8fff253
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/polaris-core/src/main/java/org/apache/polaris/core/context/RealmId.java b/polaris-core/src/main/java/org/apache/polaris/core/context/RealmId.java
@@ -37,10 +37,6 @@ static RealmId newRealmId(String id) {
     return ImmutableRealmId.of(id);
   }
 
-  static RealmId copyOf(RealmId realmId) {
-    return ImmutableRealmId.copyOf(realmId);
-  }
-
   @Value.Parameter
   @JsonValue
   String id();

diff --git a/service/common/src/main/java/org/apache/polaris/service/task/TaskExecutorImpl.java b/service/common/src/main/java/org/apache/polaris/service/task/TaskExecutorImpl.java
@@ -97,10 +97,7 @@ public void addTaskHandler(TaskHandler taskHandler) {
    */
   @Override
   public void addTaskHandlerContext(long taskEntityId, RealmId realmId) {
-    // Realm id is a request-scoped component, so we need to copy it to ensure it is available when
-    // the task is executed, even if the original realm id is no longer available because the
-    // request has completed.
-    tryHandleTask(taskEntityId, RealmId.copyOf(realmId), null, 1);
+    tryHandleTask(taskEntityId, realmId, null, 1);
   }
 
   private @Nonnull CompletableFuture<Void> tryHandleTask(