use entityexistsexception

apache · Sep 6, 2024 · e82a4a1 · e82a4a1
1 parent 51195b0
commit e82a4a1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 12 deletions.
diff --git a/...olaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java b/...olaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java
@@ -22,6 +22,7 @@
 import static org.eclipse.persistence.config.PersistenceUnitProperties.JDBC_URL;
 
 import com.google.common.base.Predicates;
+import jakarta.persistence.EntityExistsException;
 import jakarta.persistence.EntityManager;
 import jakarta.persistence.EntityManagerFactory;
 import jakarta.persistence.EntityTransaction;
@@ -261,7 +262,7 @@ public <T> T runInTransaction(
       }
     } catch (PersistenceException e) {
       if (e.toString().toLowerCase(Locale.ROOT).contains("duplicate key")) {
-        throw new IllegalStateException("Duplicate key error when persisting entity", e);
+        throw new EntityExistsException("Duplicate key error when persisting entity", e);
       } else {
         throw e;
       }

diff --git a/polaris-service/src/main/java/org/apache/polaris/service/admin/PolarisServiceImpl.java b/polaris-service/src/main/java/org/apache/polaris/service/admin/PolarisServiceImpl.java
@@ -360,11 +360,7 @@ public Response assignPrincipalRole(
         request.getPrincipalRole().getName(),
         principalName);
     PolarisAdminService adminService = newAdminService(securityContext);
-    try {
-      adminService.assignPrincipalRole(principalName, request.getPrincipalRole().getName());
-    } catch (IllegalStateException e) {
-      throw new AlreadyExistsException("Grant already exists or resolution failed");
-    }
+    adminService.assignPrincipalRole(principalName, request.getPrincipalRole().getName());
     return Response.status(Response.Status.CREATED).build();
   }
 
@@ -406,12 +402,8 @@ public Response assignCatalogRoleToPrincipalRole(
         catalogName,
         principalRoleName);
     PolarisAdminService adminService = newAdminService(securityContext);
-    try {
-      adminService.assignCatalogRoleToPrincipalRole(
-          principalRoleName, catalogName, request.getCatalogRole().getName());
-    } catch (IllegalStateException e) {
-      throw new AlreadyExistsException("Grant already exists or resolution failed");
-    }
+    adminService.assignCatalogRoleToPrincipalRole(
+        principalRoleName, catalogName, request.getCatalogRole().getName());
     return Response.status(Response.Status.CREATED).build();
   }