Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused local variables #122

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Remove unused local variables #122

merged 1 commit into from
Aug 26, 2024

Conversation

findepi
Copy link
Member

@findepi findepi commented Aug 8, 2024

No description provided.

@findepi findepi requested a review from a team as a code owner August 8, 2024 10:24
@findepi
Copy link
Member Author

findepi commented Aug 15, 2024

thank you @sfc-gh-emaynard @aihuaxu @eric-maynard @RussellSpitzer for your reviews!

i will rebase to resolve conflicts

@findepi findepi force-pushed the findepi/remove-unused-local-variables-1b3f38 branch 2 times, most recently from c0de2bb to afc61a3 Compare August 18, 2024 19:46
@findepi
Copy link
Member Author

findepi commented Aug 18, 2024

@sfc-gh-emaynard can you please approve the github workflow again?

@findepi
Copy link
Member Author

findepi commented Aug 19, 2024

thank you

@findepi findepi force-pushed the findepi/remove-unused-local-variables-1b3f38 branch from afc61a3 to 1524ad7 Compare August 23, 2024 18:33
@findepi findepi force-pushed the findepi/remove-unused-local-variables-1b3f38 branch from 1524ad7 to 9344121 Compare August 24, 2024 08:58
@findepi
Copy link
Member Author

findepi commented Aug 24, 2024

thank you @snazy @sfc-gh-ygu @flyrain for your comments!
please take another look!

flyrain
flyrain approved these changes Aug 24, 2024
View reviewed changes
Copy link
Contributor

@flyrain flyrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@snazy
Copy link
Member

snazy commented Aug 25, 2024

@findepi LGTM, just that GitHub complains that there are conflicts (but doesn't say in which files 🤷). Mind rebasing to get rid of this warning?

@findepi findepi force-pushed the findepi/remove-unused-local-variables-1b3f38 branch from 9344121 to 5ff930b Compare August 25, 2024 16:58
@findepi
Copy link
Member Author

findepi commented Aug 25, 2024

@snazy thanks, rebased!

@RussellSpitzer RussellSpitzer merged commit 29b8805 into apache:main Aug 26, 2024
3 checks passed
@RussellSpitzer
Copy link
Member

Thanks @findepi and thanks @ebyhr , @sfc-gh-emaynard , @snazy , @flyrain and @aihuaxu for review

@findepi findepi deleted the findepi/remove-unused-local-variables-1b3f38 branch August 26, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snazy snazy snazy left review comments

@eric-maynard eric-maynard eric-maynard left review comments

@aihuaxu aihuaxu aihuaxu left review comments

@sfc-gh-emaynard sfc-gh-emaynard sfc-gh-emaynard left review comments

@sfc-gh-ygu sfc-gh-ygu sfc-gh-ygu left review comments

@RussellSpitzer RussellSpitzer RussellSpitzer approved these changes

@flyrain flyrain flyrain approved these changes

@ebyhr ebyhr ebyhr approved these changes

@jbonofre jbonofre Awaiting requested review from jbonofre jbonofre is a code owner

@ashvina ashvina Awaiting requested review from ashvina ashvina is a code owner

@vvcephei vvcephei Awaiting requested review from vvcephei vvcephei is a code owner

@jackye1995 jackye1995 Awaiting requested review from jackye1995 jackye1995 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@findepi @snazy @RussellSpitzer @flyrain @ebyhr @eric-maynard @aihuaxu @sfc-gh-emaynard @sfc-gh-ygu